Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependancy on jQuery^2.1 #130

Closed
Andrew-Max opened this issue Sep 4, 2015 · 4 comments
Closed

dependancy on jQuery^2.1 #130

Andrew-Max opened this issue Sep 4, 2015 · 4 comments

Comments

@Andrew-Max
Copy link

Seems unnecessary given that there weren't api changes between 1.9 and 2.1 and the jquery < 2 allow use of older browsers.

Would it be possible to switch the Bower.json to

"jquery": ">1.9",
@danielspaniel
Copy link
Collaborator

sure thing @Andrew-Max .. this setting for query has been there for months .. never really thought about it till now. change on the way.

@danielspaniel
Copy link
Collaborator

v2.0.2 has this fix .. happy factorying!

@Andrew-Max
Copy link
Author

Woah! Warp speed patches.

I was going to offer to put in a pr but no need I guess.

Thank you so much!

@danielspaniel
Copy link
Collaborator

Your super welcome @Andrew-Max , and sure thing, next time a PR would be nice ( just fun to contribute I think )

@danielspaniel danielspaniel reopened this Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielspaniel @Andrew-Max