Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: require shim no longer working in 2.x #241

Closed
pichfl opened this issue Apr 26, 2017 · 1 comment
Closed

Investigate: require shim no longer working in 2.x #241

pichfl opened this issue Apr 26, 2017 · 1 comment
Assignees

Comments

@pichfl
Copy link
Collaborator

pichfl commented Apr 26, 2017

Seems there is some problem with the way we handle require. See #147 (comment)

This used to work and as I refactored there, I might have made an error. Will investigate.

@pichfl pichfl self-assigned this Apr 26, 2017
@bendemboski
Copy link
Member

I don't think there's a bug -- the comment was updated to indicate that it was a require vs. requireNode problem.

At some point it might be worth looking to getting rid of that by using loader.js's noConflict functionality...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants