-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cut instead of $CUT #490
Conversation
Add check of CUT. CUT is needed for a proper setting of LIB_DIR in CYGWIN.
cut is only use once for CYGWIN check UNAME_OS := $(shell $(UNAME) -s | $(CUT) -f1 -d_). May just use |
@sophia-guo can you please elaborate more? Do yo recomend to use I'm missing some detection of the cut. Where do you expect it to be set? Can you point us? |
@RadekCap maybe you can add fallback? if |
use cut instead of $CUT
Add debug message about used LIB_DIR.
@sophia-guo updated as requested. I've added a debug message for LIB_DIR as well. |
I think the verification that the cut is on path should be done. Also i think that calling cut without $(CUT) is bad code. |
I think the |
Just to summ this up - we agreed it should be checked - but the patch was approvred without the check. Am I right or am reading it wrong? I know the proper gues/set/check if is nto exactly plesant, but Radek's original commit was very close to it. Also I agree it is super minor thing, but I feel very very uncomfortable about it:( Do we agree on finish it properly (@RadekCap please?), or do you really want to set this precedent? |
Add check of CUT.
CUT is needed for a proper setting of LIB_DIR in CYGWIN.