-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openjdk.test.debugging/build.xml to build jdk-25+ using asm.jar prereq #496
Conversation
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
The path changed from Also the target build-java-25-plus are exactly same as build-java-above-11 Wondered could this be done by simply updating the target build-java-11 to work for 25+ as build-java-11 and 25 plus, and update build-java-above-11 to build-java-17-24? |
The imports all changed from:
to
We could try changing the src_150 to have a subsitituion variable which the ant make file replaced, eg:
but I prefer simplicity. |
Oh hang on, I see what you mean @sophia-guo the src_80 code is the same.... yeah didn't see that, let me check |
Hmm, I don't understand this, my assumption was the src_80_110 was different, but as you've highlighted @sophia-guo it is identical... Both src_80_110 and src_150 are identical apart from the "import's". I'm going to close this, as this needs further consideration, maybe by J9 team? |
Fixes #495
Update openjdk.test.debugging/build.xml to build jdk-25+ using asm.jar prereq rather than openjdk internal asm resources which have now moved to testlibrary (https://bugs.openjdk.org/browse/JDK-8346986).
Test builds: