Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set native tests as separate test cases #1920

Closed
sophia-guo opened this issue Jul 27, 2020 · 5 comments · Fixed by #1921
Closed

Set native tests as separate test cases #1920

sophia-guo opened this issue Jul 27, 2020 · 5 comments · Fixed by #1921

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Jul 27, 2020

java/foreign/TestNative.java depends on the testImages. For cases there is no testimages available it should be labeled as <type>native</type>.

Since these individual test classes are moved into native targets in the playlist.xml file, they will also be excluded in the problem list, so they are not included in their original test targets which are often run without the native test images being passed to the test job. Ideally native test images would be passed through always (but in reality since it is not the case, this is the approach to ensure the tests can be run, but do not fail when no native test images available.

@sophia-guo
Copy link
Contributor Author

Another one in java_lang: java/lang/ProcessBuilder/checkHandles/CheckHandles.java

@smlambert
Copy link
Contributor

Right, I see your draft PR, if we can create a single jdk_lang_native target with multiple single classes in the list to execute, that will be ideal. 👍

@sophia-guo sophia-guo changed the title Set java/foreign/TestNative.java as a separate test case Set native tests as separate test cases Jul 29, 2020
@sophia-guo
Copy link
Contributor Author

Those tests are scattered everywhere. The first one belongs to java_foreign and second one belongs to jdk_lang. If we'd like to use a single target to exclude those classes the easiest way should be set the target at openjdk hg :-(.

I'm using this issue as the permanent exclude references due to the same reason.

@sophia-guo
Copy link
Contributor Author

JDK15+ in jdk_lang: jdk/internal/loader/NativeLibraries/Main.java jdk15+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants