Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized VM option 'EnableExtendedHCR' from IllegalAccessProtectedMethodTest_0 suite #5393

Closed
sxa opened this issue Jun 17, 2024 · 7 comments · Fixed by eclipse-openj9/openj9#19717

Comments

@sxa
Copy link
Member

sxa commented Jun 17, 2024

Seen in adoptium/infrastructure#3598 (comment)
Looks to have been added in #5385

@JasonFengJ9 Is this a J9-specific option?

@JasonFengJ9
Copy link
Contributor

Is this a J9-specific option?

@sxa Yes, it was added to serviceability_jvmti_j9 via

@sxa
Copy link
Member Author

sxa commented Jun 17, 2024

Seems reasonable ... looking further the line that's in my log is:

 "/home/jenkins/workspace/Test_openjdk21_hs_extended.functional_riscv64_linux/jdkbinary/j2sdk-image/bin/java"   \
 -XX:+EnableExtendedHCR \

which is not the same as your code which has that new parameter directly after -Xmx512 so I'm wondering if it has sneaked in somewhere else for the test suite on hotspot variants.

@smlambert recommended re-running with the DYNAMIC_COMPILE option which I did at https://ci.adoptium.net/job/Grinder/10401 but that has not changed the result - same error message.

@pshipton
Copy link
Contributor

@JasonFengJ9
Copy link
Contributor

The OpenJ9 test needs to be split to have a hotspot variant.

The OpenJ9 playlist needs the following <impls> otherwise it can't be consumed by Adoptium hotspot tests.

		<impls>
			<impl>openj9</impl>
			<impl>ibm</impl>
		</impls>

@LongyuZhang
Copy link
Contributor

I will split the the test IllegalAccessProtectedMethodTest to have openj9 and hotspot variant then.

@pshipton
Copy link
Contributor

eclipse-openj9/openj9#19554 added the option to quite a few tests, I'm not sure how many of them run on hotspot. I'm also wondering if all these tests need to have the option added. There is a bug being fixed via eclipse-openj9/openj9#19710

@LongyuZhang
Copy link
Contributor

Checked all other tests in playlist.xml modified by eclipse-openj9/openj9#19554, they are all openj9 and ibm only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants