-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reproducibility percentage to daily build summary #1113
base: master
Are you sure you want to change the base?
Add reproducibility percentage to daily build summary #1113
Conversation
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
By platform and version, with the addition of a useful map for easy conversion between platform formats. Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment on the significance of "10" ?
I've updated the live Slack job to use this PR, to see how it looks for a few days... |
If the wget url retrieves an empty json, we get a string length of 2 due to the square brackets. Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
@andrew-m-leonard - Thanks for the reviews. I've tweaked the relevant code. Let me know if this works for you. :) |
@adamfarley I've just done a run using your latest code: https://adoptium.slack.com/archives/C09NW3L2J/p1728486568438139 The jdk-21.0.5+9-ea has run with tests enabled... here: https://trss.adoptium.net/allTestsInfo?buildId=66ff33dad24e1b006e7b75f0&limit=1&hasChildren=false |
Signed-off-by: Adam Farley <adfarley@redhat.com>
…ty_percentage_to_daily_build_summary
Signed-off-by: Adam Farley <adfarley@redhat.com>
Signed-off-by: Adam Farley <adfarley@redhat.com>
Ok, I think I've fixed it. I'm rerunning the test job now. |
@@ -666,23 +788,59 @@ node('worker') { | |||
} | |||
} else { | |||
// Check if build in-progress | |||
inProgressBuildUrl = getInProgressBuildUrl(trssUrl, variant, featureRelease, status['expectedReleaseName'].replaceAll("-beta", ""), status['upstreamTag']+"_adopt") | |||
(probableBuildUrl, probableBuildIdForTRSS, probableBuildStatus) = getBuildUrl(trssUrl, variant, featureRelease, status['expectedReleaseName'].replaceAll("-beta", ""), status['upstreamTag']+"_adopt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "getInProgressBuildUrl" was originally added to purely see if A build was in-progress for the given tag, regardless of what platform, is was just a "rough" status as to "is there anything still going...?"
Thus it's intention was not for finding a "specific" build, which is what I think we need now, the situation can be that in TRSS there could be several entries for a given tag say "jdk-21.0.5+9-ea", which has 334 and 335, as Windows_aarch64 was re-run... As it stands the above will find 335(WindowsAarch64) and incorrectly think no ReproducibleTest ran for x64Linux, which is in 334.
We could update verifyReleaseContent() to add the list of platforms that were found/built to the status[] json (eg.status['foundAssets']), and update getBuildUrl to take a build platform, and find the TRSS build entry for the given tag that has that build platform...?
Where we have implemented testing for a reproducible build, this code ensures that the results of that testing are included in the daily build summary.
If we did try to run the tests, but failed for whatever reason, we provide a short summary of the relevant platforms and provide a lot more information in the "details" link to the jenkins job that generates the summary, as well as useful links.
Resolves #1091