linter fixes

adoptium · Sep 18, 2023 · 1d5931c · 1d5931c
1 parent 0499c42
commit 1d5931c
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 71 deletions.
diff --git a/.github/linters/.markdown-lint.yml b/.github/linters/.markdown-lint.yml
@@ -0,0 +1,24 @@
+###########################
+###########################
+## Markdown Linter rules ##
+###########################
+###########################
+
+# Linter rules doc:
+# - https://github.com/DavidAnson/markdownlint
+#
+# Note:
+# To comment out a single error:
+#   <!-- markdownlint-disable -->
+#   any violations you want
+#   <!-- markdownlint-restore -->
+#
+
+###############
+# Rules by id #
+###############
+MD013: false # Line length is usually not important and the 80 char limit is way too small anyway
+MD026: false # Trailing punctuation in header
+MD033: false # Inline HTML is important for multilines and checkboxes within markdown tables
+MD034: false # no-bare-urls Bare URL used
+MD029: false # Markdown automatically calculates the ordered list order
diff --git a/404.html b/404.html
diff --git a/README.md b/README.md
@@ -7,7 +7,8 @@ The next gen download dashboard
 ## Local run/development steps
 
 - start DownloadStats
-```
+
+```bash
 npm install
 npm start
 ```
@@ -17,9 +18,9 @@ npm start
 ## Deployment
 
 - Compile and generate static files
-```
+
+```bash
 npm run-script build
 ```
 
 - serve ./dist
-
diff --git a/index.html b/index.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html lang="en">
   <head>
     <meta charset="UTF-8">

diff --git a/src/Graph/Trends.js b/src/Graph/Trends.js
@@ -7,6 +7,18 @@ import moment from 'moment'
 import { Radio, Slider, Checkbox } from 'antd'
 import './Trends.css'
 
+const TypeFilter = ({ defaultValue, onChange, options }) => (
+  <div className='column'>
+    <div>Type</div>
+    <Radio.Group
+      name='type'
+      defaultValue={defaultValue}
+      onChange={onChange}
+      options={options}
+    />
+  </div>
+);
+
 export default class Trends extends Component {
   state = {
     series: undefined,
@@ -146,18 +158,14 @@ export default class Trends extends Component {
             onChange={e => { args.visible = e.target.checked; updateFunc() }}
           />
         </div>
-        <div className='column'>
-          <div>Type</div>
-          <Radio.Group
-            name='type'
-            defaultValue={args.type}
-            onChange={e => { args.type = e.target.value; updateFunc() }}
-            options={[
-              { label: 'Daily', value: 'daily' },
-              { label: 'Total', value: 'total' }
-            ]}
-          />
-        </div>
+        <TypeFilter 
+          defaultValue={args.type}
+          onChange={e => { args.type = e.target.value; updateFunc() }}
+          options={[
+            { label: 'Daily', value: 'daily' },
+            { label: 'Total', value: 'total' }
+          ]}
+        />
         {this.renderFilters(args, updateFunc)}
       </div>
     )
@@ -166,18 +174,14 @@ export default class Trends extends Component {
   renderMonthlyFilters (args, updateFunc) {
     return (
       <div className='filters'>
-        <div className='column'>
-          <div>Type</div>
-          <Radio.Group
-            name='type'
-            defaultValue={args.type}
-            onChange={e => { args.type = e.target.value; updateFunc() }}
-            options={[
-              { label: 'Monthly', value: 'monthly' },
-              { label: 'Total', value: 'total' }
-            ]}
-          />
-        </div>
+        <TypeFilter 
+          defaultValue={args.type}
+          onChange={e => { args.type = e.target.value; updateFunc() }}
+          options={[
+            { label: 'Monthly', value: 'monthly' },
+            { label: 'Total', value: 'total' }
+          ]}
+        />
         {this.renderFilters(args, updateFunc)}
       </div>
     )