Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-aws-ubuntu1804-armv8-1 missing language dependency for test #1268

Closed
M-Davies opened this issue Apr 9, 2020 · 9 comments
Closed

test-aws-ubuntu1804-armv8-1 missing language dependency for test #1268

M-Davies opened this issue Apr 9, 2020 · 9 comments
Assignees
Labels
Milestone

Comments

@M-Davies
Copy link

M-Davies commented Apr 9, 2020

eclipse-openj9/openj9#9042

Test java/util/Locale/LocaleCategory.java has been failing on this machine due to a system language issue.

See eclipse-openj9/openj9#9042 (comment). It appears to be the LANG variable that is one factor that is causing this test to fail.

However, it is likely not the only factor.LANG is set to C.UTF-8 (the same LANG setting as test-aws-ubuntu1804-armv8-1) on cent7-aarch64-1 and the test passes. The purpose of this issue is to determine if there is something missing in the dependencies of this machine that is causing this test to fail and, if not, discuss setting the LANG variable to en_US.UTF-8 OR en_GB.UTF-8 to resolve the issue.

@sxa
Copy link
Member

sxa commented Apr 14, 2020

@Haroon-Khel Can you take a look at this and see if there's anything obvious that might be missing on test-aws-ubuntu1804-armv8-1 (34.243.202.254) - Hopefully that failure will be easy enough to reproduce when you're logged in.

@sxa sxa added this to the April 2020 milestone Apr 14, 2020
@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Apr 15, 2020

I was able to recreate the test error locally on test-aws-ubuntu1804-armv8-1. I cant find anything obvious thats missing on the machine. Even after running the Locales tasks, from the unix playbook, the test continues to fail. Continuing to investigate

@knn-k
Copy link

knn-k commented Apr 17, 2020

When I ran this LocaleCategory test on test-aws-ubuntu1804-armv8-1, its .jtr file contains the following lines -- There is no -Duser.language=en in the command line:

cd /home/konno/openjdk-tests/TKG/test_output_15864301552922/jdk_util_j9_0/work/scratch/6 && \\
HOME=/home/konno \\
LANG=C.UTF-8 \\
PATH=/bin:/usr/bin:/usr/sbin \\
(... skip ...)
        -Duser.language.display=ja \\
        -Duser.language.format=zh \\
        com.sun.javatest.regtest.agent.MainWrapper /home/konno/openjdk-tests/TKG/test_output_15864301552922/jdk_util_j9_0/work/java/util/Locale/LocaleCategory.d/main.0.jta
result: Failed. Execution failed: `main' threw exception: java.util.IllformedLocaleException: Ill-formed language: c.u [at index 0]

On the other hand, the .jtr file on cent7-aarch64-1 looks like this, and the test passes because there is -Duser.language=en in it:

cd /home/jenkins/konno/openjdk-tests/TKG/test_output_15848773744616/jdk_util_0/work/scratch/7 && \\
HOME=/home/jenkins \\
LANG=C \\
PATH=/bin:/usr/bin:/usr/sbin \\
(... skip ...)
        -Duser.language=en \\
        -Duser.language.display=ja \\
        -Duser.language.format=zh \\
        com.sun.javatest.regtest.agent.MainWrapper /home/jenkins/konno/openjdk-tests/TKG/test_output_15848773744616/jdk_util_0/work/java/util/Locale/LocaleCategory.d/main.1.jta
result: Passed. Execution successful

The LANG environment variable for the user is C.UTF-8 by default in both environments, while the .jtr file on cent7-aarch64-1 says LANG=C instead of C.UTF-8.

If you manually change LANG on test-aws-ubuntu1804-armv8-1 to en_US.UTF-8 for example, the test passes as expected.

@Haroon-Khel
Copy link
Contributor

@knn-k You're right. On test-aws-ubuntu1804-armv8-1, I have set the LANG variable to en_US.UTF-8 in /etc/default/locale and the test passes. @M-Davies is it safe to say this issue can be closed?

@Haroon-Khel
Copy link
Contributor

Odd, the test passes locally but still fails in the grinder with the original error
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2875/testReport/java_util_Locale_LocaleCategory/java/LocaleCategory/

@jdekonin
Copy link
Contributor

A possible issue, looks like the machine was connected to jenkins on April 1st and this is an environment setting change. I believe you need to disconnect the client from jenkins and reconnect to pick up the environment change.

@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Apr 20, 2020

@sxa If this is the case, then could you disconnect and reconnect the machine please?

@sxa
Copy link
Member

sxa commented Apr 22, 2020

Done - agent relaunched on test-aws-ubuntu1804-armv8-1 :-)

@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Apr 22, 2020

Ayy the test passes https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2904/testReport/java_util_Locale_LocaleCategory/java/LocaleCategory/

Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants