Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More restrictive API for String arguments #185

Closed
valb3r opened this issue Nov 21, 2019 · 4 comments · Fixed by #327
Closed

More restrictive API for String arguments #185

valb3r opened this issue Nov 21, 2019 · 4 comments · Fixed by #327
Assignees

Comments

@valb3r
Copy link
Contributor

valb3r commented Nov 21, 2019

Currently some String based constructors, factory methods that are intended for internal use (i.e. Uri, BasePrivateResource.forPrivate ...) are not safe to use with non-url safe Strings. While it does not affect global usage as *Request api can accept any type of String, it is better to hide those String (Uri, BasePrivateResource.for..) constructors as implementation detail if needed and expose url-safe variants.

@francis-pouatcha francis-pouatcha added this to To do in datasafe Dec 12, 2023
@francis-pouatcha francis-pouatcha removed this from To do in datasafe Dec 13, 2023
@francis-pouatcha
Copy link
Member

Search and find all API constructors that use String.

@forkimenjeckayang forkimenjeckayang self-assigned this Jun 25, 2024
@forkimenjeckayang
Copy link
Collaborator

Greetings Sir @francis-pouatcha , should this first of all be a documentation on URL-Safe Strings with regards to an API. Need more clarification on this ticket before working on it.

@francis-pouatcha
Copy link
Member

It is about locating which rest API have unsafe strings in their parameter.

@forkimenjeckayang forkimenjeckayang linked a pull request Jul 1, 2024 that will close this issue
@francis-pouatcha
Copy link
Member

francis-pouatcha commented Jul 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants