Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--import.managed.required-action=no-delete doesn't seem to prevent deletion #834

Closed
akikoskinen opened this issue Feb 27, 2023 · 1 comment · Fixed by #1183
Closed

--import.managed.required-action=no-delete doesn't seem to prevent deletion #834

akikoskinen opened this issue Feb 27, 2023 · 1 comment · Fixed by #1183
Assignees
Labels

Comments

@akikoskinen
Copy link
Contributor

akikoskinen commented Feb 27, 2023

Current Behavior

Keycloak-config-cli deletes all existing required actions, only leaving or creating the one mentioned in the realm JSON.

Expected Behavior

Keycloak-config-cli should leave the existing required actions untouched.

Steps To Reproduce

The realm JSON contains one required action:

...
  "requiredActions": [
    {
      "alias": "verify-email-code-action",
      "name": "Verify email by code",
      "providerId": "verify-email-code-action",
      "enabled": true,
      "defaultAction": false,
      "priority": 1001,
      "config": {}
    }
  ]
...

When running Keycloak-config-cli, the --import.managed.required-action=no-delete option is given.

Environment

  • Keycloak Version: 19.0.2
  • keycloak-config-cli Version: 5.5.0
  • Java Version: 17

Anything else?

To me it looks like RequiredActionsImportService looks for the property for client scopes, while it should probably check the required actions property.

@akikoskinen
Copy link
Contributor Author

Indeed it looks like giving the --import.managed.client-scope=no-delete option prevents deletion of pre-existing required actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants