dynamodb revisionGuardStore implementation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure "aws-sdk" should be in devDependencies section, as well as this line should be : aws = Store.use('aws-sdk');in order to not make it hard dependency. |
adrai
reviewed
Aug 10, 2017
package.json
Outdated
| @@ -12,6 +12,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "async": "1.5.2", | |||
| "aws-sdk": "2.94.0", | |||
There was a problem hiding this comment.
move this to devDependencies, please
adrai
reviewed
Aug 10, 2017
| async = require('async'), | ||
| _ = require('lodash'), | ||
| uuid = require('uuid').v4, | ||
| aws = require('aws-sdk'); |
There was a problem hiding this comment.
please write it that way: aws = Store.use('aws-sdk');
|
@emmkong seen the comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.