fix: Memory leak in repo-server (argoproj#20876)

Signed-off-by: Adam Chandler <adam_chandler@trimble.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
adriananeci · Dec 4, 2024 · 6690822 · 6690822
1 parent 4c529f4
commit 6690822
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/util/app/discovery/discovery.go b/util/app/discovery/discovery.go
@@ -170,6 +170,7 @@ func cmpSupports(ctx context.Context, pluginSockFilePath, appPath, repoPath, fil
 	cfg, err := cmpClient.CheckPluginConfiguration(ctx, &empty.Empty{})
 	if err != nil {
 		log.Errorf("error checking plugin configuration %s, %v", fileName, err)
+		io.Close(conn)
 		return nil, nil, false
 	}
 
@@ -178,6 +179,7 @@ func cmpSupports(ctx context.Context, pluginSockFilePath, appPath, repoPath, fil
 		if namedPlugin {
 			return conn, cmpClient, true
 		}
+		io.Close(conn)
 		return nil, nil, false
 	}