Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load wordlist in memory #1

Open
ostrolucky opened this issue Apr 27, 2020 · 1 comment
Open

Don't load wordlist in memory #1

ostrolucky opened this issue Apr 27, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ostrolucky
Copy link

I reviewed the code and in my opinion one potentially big issue is just using file_get_contents to load the file. This loads whole file in memory. In my opinion library should just count number of lines in file, then generate couple numbers representing lines and read just those through seeking the file.

@adriangonzales
Copy link
Owner

Thats a great observation. I'll check it out or I'd accept a PR.

@adriangonzales adriangonzales added the enhancement New feature or request label Feb 16, 2022
@adriangonzales adriangonzales self-assigned this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants