You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the code and in my opinion one potentially big issue is just using file_get_contents to load the file. This loads whole file in memory. In my opinion library should just count number of lines in file, then generate couple numbers representing lines and read just those through seeking the file.
The text was updated successfully, but these errors were encountered:
I reviewed the code and in my opinion one potentially big issue is just using file_get_contents to load the file. This loads whole file in memory. In my opinion library should just count number of lines in file, then generate couple numbers representing lines and read just those through seeking the file.
The text was updated successfully, but these errors were encountered: