-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pdf2json to version 2 #116
Conversation
Pdfparser v2 uses private class fields, so Node 8 & 10 is expected to fail. Node 12 surprises me a bit, looks like private class fields is supported but it fails on the line linked above. But still, pdfparser explicitly states it needs node v14. Is it time to drop node 8, 10, 12? |
merging this PR implies breaking changes (and therefore a major version increase), so yes, I think it’s a good occasion to do it! Can you make that clear by updating the following files in this PR:
|
Old node branches has been deleted, 12.x removed from test |
by increasing ecmaVersion, according to node.js version upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PdfReader 2.0 is out: pdfreader - npm! 🎉 Thank you for your contribution, @copmerbenjamin! 🙌 |
Thank you @adrienjoly 🙌 |
As discussed in #114, #103, #101, MozBlobBuilder is not defined (only newer node versions tested).
The issue is resolved in pdf2json in version 2.
pdf2json v2 changed the password part a bit, this as been adjusted
v2 also removed the property oc for the pdf items, and added the prop clr. This might trigger a new major version of npm-pdfreader.
A new test snapshot have therefore been created to reflect those changes.
"Warning: Setting up fake worker." have also been removed from pdf2json.
Old test before generating new snapshots:
"C:\Program Files\nodejs\node.exe "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" test --scripts-prepend-node-path=auto