-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps)!: update pdf2json from 2.0.1 to 3.0.1 #125
Conversation
updated pdf2json version to 3.0.1 from 2.0.1
Thank you for the Pull Request, @MOUNIKA0536 ! As advised by the Continuous Integration checks (for instance, see https://github.com/adrienjoly/npm-pdfreader/actions/runs/3591072006/jobs/6053459310#step:4:5), can you make sure that |
to fix `Error [ERR_REQUIRE_ESM]: Must use import to load ES Module` cf https://github.com/adrienjoly/npm-pdfreader/actions/runs/3600927300/jobs/6066135599#step:5:18
As As this will break existing imports of |
@MOUNIKA0536 do you agree with the changes I brought to your Pull Request, in order to make sure that automated tests still pass? => Is there anything you would like to ask or suggest before I merge it, and therefore distribute the version 3.0 of |
@adrienjoly Nothing to suggest. Its good to merge. Thanks for the quick updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #124.
BREAKING CHANGE: switch
pdfreader
from commonJS to ES Module, as pdf2json did.