From e53c8025a0204d4ff3a6937c642b1497256c86e1 Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Thu, 22 Aug 2024 21:55:02 -0700 Subject: [PATCH] tres: fix SOM reset line blinking (#2003) Co-authored-by: Comma Device --- board/boards/cuatro.h | 2 +- board/boards/tres.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/board/boards/cuatro.h b/board/boards/cuatro.h index 720077def6..e3e2140e0a 100644 --- a/board/boards/cuatro.h +++ b/board/boards/cuatro.h @@ -85,8 +85,8 @@ void cuatro_init(void) { set_gpio_pullup(GPIOC, 2, PULL_DOWN); // SOM bootkick + reset lines - set_gpio_mode(GPIOC, 12, MODE_OUTPUT); tres_set_bootkick(BOOT_BOOTKICK); + set_gpio_mode(GPIOC, 12, MODE_OUTPUT); // SOM debugging UART gpio_uart7_init(); diff --git a/board/boards/tres.h b/board/boards/tres.h index fdd4cb19d5..d3b5f0caa9 100644 --- a/board/boards/tres.h +++ b/board/boards/tres.h @@ -42,8 +42,9 @@ void tres_init(void) { set_gpio_pullup(GPIOC, 2, PULL_DOWN); // SOM bootkick + reset lines - set_gpio_mode(GPIOC, 12, MODE_OUTPUT); + // WARNING: make sure output state is set before configuring as output tres_set_bootkick(BOOT_BOOTKICK); + set_gpio_mode(GPIOC, 12, MODE_OUTPUT); // SOM debugging UART gpio_uart7_init();