Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Logo set with WPML not Showing in 3.4.0 and forward #469

Closed
hans-olson opened this issue May 12, 2020 · 2 comments
Closed

Custom Logo set with WPML not Showing in 3.4.0 and forward #469

hans-olson opened this issue May 12, 2020 · 2 comments
Assignees

Comments

@hans-olson
Copy link
Contributor

Version of ALPS for Wordpress
v3.4.0

Describe the bug
Custom Logo not Showing in 3.4.0

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://sandbox12.adventist.io/'
  2. Click on 'ALPS Theme Settings' under 'Appearance'
  3. See logo is customized, but not showing on the site
  4. Also see that there is not an option to add multi-lingual logo options

Screenshots
Screen Shot 2020-05-12 at 6 59 41 PM
Screen Shot 2020-05-12 at 7 01 28 PM
Screen Shot 2020-05-12 at 7 01 06 PM
Screen Shot 2020-05-12 at 7 00 42 PM

Additional context
See correct on dev.sharinghope.com and wrong on sandbox12.adventist.io

@hans-olson
Copy link
Contributor Author

hans-olson commented May 15, 2020

The custom logo not appearing on dev.sharinghope.com in 3.4.x is related to WPML. When I turned WPML off in the staging site (sandbox12.adventist.io), the logo immediately appeared.

This issue is currently fixed on dev.sharinghope.com by a robust child theme that overwrites much of 3.4.x with 3.3.0. I've tested with 3.4.0 and 3.4.1.

@hans-olson
Copy link
Contributor Author

hans-olson commented May 15, 2020

The logo issue is with this file /app/fields.php.

This issue is handled by a child theme that overwrites parts of 3.4.x with 3.3.0. I've tested with 3.4.0 and 3.4.1. Once WPML is disabled, the logo appears! The logo issue is with this file /app/fields.php.

Also, parts of the "app" and "dist" folders are need otherwise site breaks.

I'm attaching a ZIP of the child theme
alps-wordpress-v3-sharinghope-1-3-4-0.zip

@designerbrent designerbrent changed the title Custom Logo not Showing in 3.4.0 Custom Logo set with WPML not Showing in 3.4.0 and forward Jun 1, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants