Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Tertiary Menus #341

Closed
designerbrent opened this issue Aug 8, 2019 · 10 comments
Closed

Support for Tertiary Menus #341

designerbrent opened this issue Aug 8, 2019 · 10 comments
Assignees
Labels
ALPS v.3 Tickets for the ALPS v.3 development enhancement URGENT
Milestone

Comments

@designerbrent
Copy link
Collaborator

This ticket is to add in support for the tertiary menu pattern being added in adventistchurch/alps#399.

@designerbrent designerbrent added ALPS v.3 Tickets for the ALPS v.3 development enhancement labels Aug 8, 2019
@designerbrent designerbrent added this to the 3.1 milestone Aug 8, 2019
@davideleuterius
Copy link
Contributor

@designerbrent
I have this coded out now. @kelscahill is working on the front end presentation for this one.

@designerbrent
Copy link
Collaborator Author

@davideleuterius I just committed adventistchurch/alps#399 so this is now ready to go. 👍

@designerbrent
Copy link
Collaborator Author

Please add this in a separate PR then #356.

@davideleuterius
Copy link
Contributor

@designerbrent
I am back today after some long-scheduled time off. Just so that I understand you properly, you want me to add the code for this as a completely separate pull request, but also include it in with branch v3.310-carbon-fields?

@designerbrent
Copy link
Collaborator Author

@davideleuterius Since this work is separate from #310 and doesn't reference piklist, I would prefer to review it separately from that work. Obviously it will merge in the the v3 branch, either before #356 or after but it makes it easier to evaluate and test if it is isolated.

@designerbrent designerbrent modified the milestones: 3.1, 3.0 Oct 15, 2019
@kelscahill
Copy link
Collaborator

@davideleuterius is there a PR for this? I am looking into issue #363, but am wondering if the tertiary menu code was even merged yet.

cc @designerbrent

@davideleuterius
Copy link
Contributor

@kelscahill I will get this done shortly and let you know when this is ready.

cc @designerbrent

@davideleuterius
Copy link
Contributor

@kelscahill @designerbrent
Looks like I put this in a new template in PR 356 some time ago, but it is in a completely separate and new template ( views/patterns/01-molecules/navigation/primary-navigation-tertiary.blade.php ). This isn't being called on anywhere yet, so what I will do is create a new branch, integrate that code into the primary-navigation-blade.php and add a pull request for that.

@davideleuterius
Copy link
Contributor

@kelscahill @designerbrent
I've created a new pull request for this: PR #364

kelscahill pushed a commit that referenced this issue Oct 29, 2019
kelscahill pushed a commit that referenced this issue Oct 29, 2019
@kelscahill
Copy link
Collaborator

@designerbrent PR is merged and this is good for testing.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALPS v.3 Tickets for the ALPS v.3 development enhancement URGENT
Projects
None yet
Development

No branches or pull requests

4 participants