Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make theme elements translatable #549

Closed
slatinasda opened this issue Nov 26, 2021 · 1 comment
Closed

Make theme elements translatable #549

slatinasda opened this issue Nov 26, 2021 · 1 comment

Comments

@slatinasda
Copy link

slatinasda commented Nov 26, 2021

Version of ALPS for Wordpress

  • 3.11.4

Description:

At the moment, not all theme elements are translatable:

Non-translatable button

Upon inspecting the DOM element of this button, I saw that the label "Show" comes from the CSS file of the theme (main-campfire in my case), which by default is loaded from the CDN:
https://cdn.adventist.org/alps/3/3.11.4/css/main-campfire.css

I tried generating translation .po and .mo files for my target language and installing them in the Wordpress theme, but it didn't solve the issue.

I inspected this repository and saw a couple of cases where the English version of those labels are hard-coded into the CSS:

content: "Show";

content: "Close";

content: "Show More";

Temporary solution

  1. Go to the ALPS theme settings in Wordpress
  2. Navigate to the ALPS Core files version section
  3. Select the LOCAL option, in order to load the main theme files from the local installation
  4. Open the CSS file of the currently selected theme (main-campfire in my case): wp-content/themes/alps-wordpress-v3/app/local/alps/3.11.4/css/3.11.4-main-campfire.css
  5. Translate all hard-coded strings in your target language

Note: This doesn't solve the issue for multilingual sites, as it will only display the text in 1 language.
Note 2: Doesn't work well, because upon theme update, you need to update the translations again

Related issue

adventistchurch/alps-wordpress#549

@hans-olson
Copy link
Contributor

This is being worked on in this issue adventistchurch/alps-wordpress#627

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants