Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plus signs not encoded when switching to UrlEncode mode #3

Closed
crashdemons opened this issue May 2, 2015 · 0 comments
Closed

Plus signs not encoded when switching to UrlEncode mode #3

crashdemons opened this issue May 2, 2015 · 0 comments
Assignees
@crashdemons
Labels
bug

Comments

@crashdemons
Copy link
Member

when switching to UrlEncode mode from data containing plus signs (when interpreted as bytes) only the first sign is replaced with %2B correctly.

This is due to mistakenly using the standard one-time-replace function (why does that exist) instead of implementing a replaceAll function. Ref the below line:
https://github.com/crashdemons/JXlate/blob/7b6c37976fe4928799586cdc6d97f297aeb3f5ab/src/js/xlate.js#L144
@crashdemons crashdemons added the bug label May 2, 2015
@crashdemons crashdemons self-assigned this May 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crashdemons crashdemons

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crashdemons