Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add strict analyser rules #320

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Feat: Add strict analyser rules #320

wants to merge 11 commits into from

Conversation

guillaumetavernier
Copy link
Contributor

Close #210

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 49.70588% with 171 lines in your changes are missing coverage. Please review.

Project coverage is 54.45%. Comparing base (cc11563) to head (4807a99).

Files Patch % Lines
lib/tools/repository/repository.dart 0.00% 115 Missing ⚠️
lib/login/repositories/sign_up_repository.dart 0.00% 6 Missing ⚠️
lib/recommendation/class/recommendation.dart 14.28% 6 Missing ⚠️
lib/vote/repositories/status_repository.dart 0.00% 6 Missing ⚠️
lib/auth/providers/openid_provider.dart 0.00% 5 Missing ⚠️
lib/tools/repository/logo_repository.dart 0.00% 5 Missing ⚠️
...ib/amap/repositories/delivery_list_repository.dart 0.00% 4 Missing ⚠️
lib/tools/functions.dart 0.00% 4 Missing ⚠️
lib/tools/token_expire_wrapper.dart 0.00% 3 Missing ⚠️
lib/user/repositories/user_repository.dart 0.00% 3 Missing ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   55.79%   54.45%   -1.35%     
==========================================
  Files         164      164              
  Lines        3579     3684     +105     
==========================================
+ Hits         1997     2006       +9     
- Misses       1582     1678      +96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

julien4215
julien4215 requested changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@julien4215 julien4215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot login. Also it seems that there are type errors in advert module.

@guillaumetavernier guillaumetavernier marked this pull request as draft March 12, 2024 12:06
@armanddidierjean armanddidierjean added enhancement New feature or request core This PR change the core ci/cd This PR works on the CI/CD labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien4215 julien4215 julien4215 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci/cd This PR works on the CI/CD core This PR change the core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analyzer improvements
4 participants
@guillaumetavernier @codecov-commenter @julien4215 @armanddidierjean