Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for Redgifs embedded media #1505

Closed
net00-1 opened this issue May 30, 2024 · 0 comments
Closed

Small fix for Redgifs embedded media #1505

net00-1 opened this issue May 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@net00-1
Copy link
Contributor

net00-1 commented May 30, 2024

Is your feature request related to a problem? Please describe.

  • Many Redgifs uploads are done using the v3.redgifs.com subdomain. Voyager treats these links as regular link posts instead of embedding the media. For example https://lemmynsfw.com/post/12153533 (NSFW)

Describe the solution you'd like

  • Redgifs link detection seems to be done in src/features/media/external/redgifs/helpers.ts with regex:

    • ^https:\/\/(?:www\.)?redgifs.com\/watch\/([a-z]+)
  • I added v3 subdomain like so https:\/\/(?:www\.|v3\.)?redgifs.com\/watch\/([a-z]+) within my fork. After building the app for iOS I see that links with v3 subdomain are now properly embedded as well. I tested this with iPad and iPhone on iOS 17.5.1

Describe alternatives you've considered

  • N/A

Additional context

@net00-1 net00-1 added the enhancement New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant