-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library fails to handle epub where some items in content.xml are missing #281
Comments
Here's a patch to
Not making a PR because I patched this by just editing the installed library directly. Principally, you now get a |
Functionally the title:
These are in epub files generated by Kobo Books. They also render fine in about every epub reader I've tried to view them in. The js file is not needed for the e-book to be completely readable.
One single file missing should not prevent opening the file overall.
What occurs to me is that if a link to a internal file is broken, there should be some sort of internal object that represents a "error condition" or similar.
This issue is a generalization of a bunch of open issues:
Really, what occurs to me is that trying to read everything in the
content.xml
file up-front is probably the core of the issue. Each sub-element in the file should be read lazily as they're accessed. Then you could throw an error at the appropriate time.The text was updated successfully, but these errors were encountered: