Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth headers to vnc connections #332

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

regbo
Copy link

@regbo regbo commented Oct 5, 2020

Right now usernames, passwords, and wss urls are ignored in the quota file when connecting to VNC. I've added a couple of methods that will add an authorization header and use WSS when required.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 88.06%. Comparing base (475a1d3) to head (b73b32b).
Report is 67 commits behind head on master.

❗ Current head b73b32b differs from pull request most recent head 5b9f2ac. Consider uploading reports for the commit 5b9f2ac to get more accurate results

Files Patch % Lines
proxy.go 50.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   90.28%   88.06%   -2.23%     
==========================================
  Files           4        4              
  Lines         659      595      -64     
==========================================
- Hits          595      524      -71     
- Misses         51       57       +6     
- Partials       13       14       +1     
Flag Coverage Δ
go 88.06% <50.00%> (-2.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vania-pooh vania-pooh requested a review from aandryashin October 6, 2020 17:02
@stale
Copy link

stale bot commented Dec 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 5, 2020
@stale stale bot closed this Dec 12, 2020
@vania-pooh vania-pooh reopened this Dec 13, 2020
@stale stale bot removed the stale label Dec 13, 2020
@github-actions github-actions bot added stale and removed stale labels Jan 10, 2024
@github-actions github-actions bot added stale and removed stale labels Mar 12, 2024
@github-actions github-actions bot added the stale label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants