Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vec 189 tls #2

Merged
merged 17 commits into from
Jul 3, 2024
Merged

Vec 189 tls #2

merged 17 commits into from
Jul 3, 2024

Conversation

jdogmcsteezy
Copy link

Add tls and user/pass authentication. This PR does not include managing the ACL.

@jdogmcsteezy jdogmcsteezy requested a review from dwelch-spike July 2, 2024 22:01
dwelch-spike
dwelch-spike reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks and wondering if newTLSConfig from utils.go is used? Otherwise, once you have had a look, LGTM. (ignoring tests and linter errors as discussed)

cmd/createIndex.go Show resolved Hide resolved
cmd/createIndex.go Show resolved Hide resolved
cmd/dropIndex.go Show resolved Hide resolved
cmd/flags/tls.go Outdated Show resolved Hide resolved
cmd/flags/tls.go Outdated Show resolved Hide resolved
cmd/utils.go Show resolved Hide resolved
docker/auth/config/tls/localhost.keystore.jks Outdated Show resolved Hide resolved
docker/auth/config/jwt/private_key.pem Outdated Show resolved Hide resolved
cmd/utils.go Outdated Show resolved Hide resolved
jdogmcsteezy
jdogmcsteezy commented Jul 3, 2024
View reviewed changes
Copy link
Author

@jdogmcsteezy jdogmcsteezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replied

@dwelch-spike dwelch-spike self-requested a review July 3, 2024 16:42
dwelch-spike
dwelch-spike approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy merged commit 5700529 into main Jul 3, 2024
2 of 4 checks passed
@jdogmcsteezy jdogmcsteezy deleted the VEC-189-tls branch October 1, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwelch-spike dwelch-spike dwelch-spike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdogmcsteezy @dwelch-spike