feat: VEC-185 allow index definitions in yaml as input and output #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage ? 79.55%
=======================================
Files ? 34
Lines ? 1996
Branches ? 0
=======================================
Hits ? 1588
Misses ? 344
Partials ? 64 ☔ View full report in Codecov by Sentry. |
dwelch-spike
approved these changes
Aug 5, 2024
cmd/indexCreate.go
Outdated
Comment on lines
142
to
171
| if err != io.EOF { | ||
| logger.Error("failed to unmarshal index definitions", slog.Any("error", err)) | ||
| return err | ||
| } | ||
|
|
||
| logger.Debug("read index definitions from stdin", slog.Any("data", data)) | ||
|
|
||
| // Unmarshal YAML data | ||
| intermediate := map[string]interface{}{} | ||
| err = yaml.Unmarshal([]byte(data), &intermediate) | ||
| if err != nil { | ||
| logger.Error("failed to unmarshal index definitions", slog.Any("error", err)) | ||
| return err | ||
| } | ||
|
|
||
| jsonBytes, err := json.Marshal(intermediate) | ||
| if err != nil { | ||
| logger.Error("failed to marshal index definitions", slog.Any("error", err)) | ||
| return err | ||
| } | ||
|
|
||
| logger.Debug("marshalled index definitions", slog.Any("data", string(jsonBytes))) | ||
|
|
||
| stdinIndexDefinitions = &protos.IndexDefinitionList{} | ||
|
|
||
| err = protojson.Unmarshal(jsonBytes, stdinIndexDefinitions) | ||
| if err != nil { | ||
| logger.Error("failed to unmarshal index definitions", slog.Any("error", err)) | ||
| return err | ||
| } |
There was a problem hiding this comment.
nit: I think these log lines should include what kind of marshaling/unmarshaling that failed so it's easier to tell which step failed from the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following 3 cmds will now work:
asvec index list --yaml > indexDef.yamlcat indexDef.yaml | asvec index createasvec index create --file indexDef.yaml