Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure kanren rewrites account for SharedVariable.default_updates #108

Open
brandonwillard opened this issue Feb 17, 2023 · 0 comments
Open

Make sure kanren rewrites account for SharedVariable.default_updates #108

brandonwillard opened this issue Feb 17, 2023 · 0 comments
Assignees
@brandonwillard @rlouf @zoj613
Labels
bug Something isn't working important miniKanren question Further information is requested

Comments

@brandonwillard
Copy link
Member

We need to make sure that our kanren-based rewrites (e.g. conjugates) update the RNG SharedVariable.default_updates; otherwise, we'll get implicit updates that include the original non-conjugated graphs in the compiled results.
@brandonwillard brandonwillard added bug Something isn't working important question Further information is requested miniKanren labels Feb 17, 2023
@brandonwillard brandonwillard changed the title Make sure kanren rewrites compensate for SharedVariable.default_updates Make sure kanren rewrites account for SharedVariable.default_updates Feb 17, 2023
@brandonwillard brandonwillard mentioned this issue Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonwillard brandonwillard

@rlouf rlouf

@zoj613 zoj613

Labels
bug Something isn't working important miniKanren question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brandonwillard @rlouf @zoj613