Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Disable for TypeScript 4.2+ #22

Closed
mjbvz opened this issue Feb 23, 2021 · 2 comments
Closed

Disable for TypeScript 4.2+ #22

mjbvz opened this issue Feb 23, 2021 · 2 comments
Assignees
Milestone

Comments

@mjbvz
Copy link

mjbvz commented Feb 23, 2021

Semantic highlighting support should now be built into the TypeScript server. We should :

  • Quickly test to make sure there are no major regressions with the native TypeScript support
  • Disable this plugin by default when the plugin is run with TypeScript 4.2
  • At some point in the future (after giving users enough time to update to newer TS versions) stop including this plugin with VS Code.
@aeschli
Copy link
Owner

aeschli commented Mar 16, 2021

I tested that the tests also run with the built-in '2020' typescript support.
The plugin will not intercept when in >= 4.2

@aeschli aeschli closed this as completed Mar 16, 2021
@jasonlyu123
Copy link

Hi. As far as I know. typescript's built-in semantic highlighting doesn't work with js files.
https://github.com/microsoft/TypeScript/blob/b1571fcb71501d16f21173979365d4c4d53a11cb/src/services/services.ts#L1888

I checked with the insider version of vscode. Semantic highlight no longer show up on js files on 1.55.0 insider with commit d06d2f1d6245ce00b1c36a9cd81a9087d225173e.

insider version:
圖片

1.54:
圖片

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants