Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action is not compatible with docker/build-push-action #9

Open
somdoron opened this issue Jun 20, 2020 · 4 comments
Open

action is not compatible with docker/build-push-action #9

somdoron opened this issue Jun 20, 2020 · 4 comments

Comments

@somdoron
Copy link
Contributor

I think making them compatible will increase the usage of this action.

  1. build-push-action has repository option vs image option on action-kanino.
  2. dockerfile vs build_file
  3. build_args is missing (comma separated)
  4. tags is missing (comma separated)

@aexvir if you would like I can make a pull request to make them (more) compatible. However, it will probably break the current options.

@aexvir
Copy link
Member

aexvir commented Jun 22, 2020

👋 Hi there @somdoron
Hmm, not fully sure why making this action a drop-in replacement for docker's one is necessary, but I don't see any big reason against it either, so let's go for it.

I'd personally avoid making blatant breaking changes, but to be honest I'm not sure how much people is currently using the action... I don't think that adding a fallback to the current vars is too hard to do, and we can even display a deprecation notice for it. What do you think?

But yep, please feel free to submit a PR addressing this 🙂

@hadim
Copy link

hadim commented Jun 22, 2020

I agree it would be a nice feature to have so it's possible to switch the "builder backend" by editing a simple line. The drawback is backward compatibility but since this action is young, it might actually be a good time to do it now before it's too late.

@somdoron
Copy link
Contributor Author

I will give it a try with backward compatibility

@aexvir aexvir mentioned this issue Sep 17, 2020
@aexvir
Copy link
Member

aexvir commented Sep 17, 2020

@somdoron did you end up giving a try to make this change?
Otherwise I'll look into it this weekend 🙂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants