Gigantic Refactor #137
Merged
Gigantic Refactor #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
pushed a commit
to devildahu/bevy_mod_picking
that referenced
this pull request
Jan 19, 2023
* Simplify highlighting assets further * WIP commit to capture refactor progress * more wip * wip * wip * Update LICENSE * input refactor * functioning cursor hits with raycast backend * hovering working, selection buggy * system ordering cleanup * selection wip * fixed inputs and hits * fix click events * event based picking * explicitly track interaction state * event based interaction rewrite * Get multi window example working * cleanup * more cleanup * working bubbling * command callbacks * impl event forwarding command * gltf picking * drag events * remove unused module * cleanup * better backend names * Split out highlight and selection as crates and make optional * fix up examples * clippy * update licenses * Fix ordering bug * Update presentmode * improve multi window example * dragover and drop events * doc comments * Document evenrything * refactor selection to match updated crates * Improve selection docs * doc polish * improve docs * remove unused vars from query * add working rapier deps * comment out reference code * rapier backend * Cleanup, bugfixing * mark shader plugin as unimplemented * Add some example comments * Add more description for pointer ids and bundles * Update crates/backends/bevy_picking_shader/NOTES.md Co-authored-by: colepoirier <37318670+colepoirier@users.noreply.github.com> * Apply suggestions from code review Rename `EventFrom` to `ForwardedEvent` Co-authored-by: colepoirier <37318670+colepoirier@users.noreply.github.com> * Add more documentation * use git instead of local dep * fix dev deps for examples * update crate releases * review feedback, pointer bundle docs * forwarding cont * bevy ui picking backend * working bevy ui impl * Add drag and drop * Fix tests and docs * cleanup * review feedback * review feedback * touch fixes * fix touch input * wip debugging touch raise events * more notes * more notes * refactoring * fix missing touch click/drop events * cleanup * improve drag and drop example * update drag and drop example * remove errant import * remove dragover debug spam * fix drag leave bug caused by drag over only using a single entity * minor fixes * fix multiselect * Add debug text * license and font * bevy 0.9 * Impl sprite picking, add pointer debug reticle, tidy examples * CI fixes Co-authored-by: colepoirier <37318670+colepoirier@users.noreply.github.com>
aevyrie
added a commit
that referenced
this pull request
May 3, 2023
* Gigantic Refactor (#137) --------- Co-authored-by: colepoirier <37318670+colepoirier@users.noreply.github.com> Co-authored-by: Aceeri <conmcclusk@gmail.com> Co-authored-by: Nicola Papale <26321040+nicopap@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully decouples picking from both input and picking backend. Adds the ability to place event listeners on entities, and easy event-forwarding to entities on interaction.