-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal storage and remove permissions for external storage #140
Comments
Thank you for creating your first issue. We appreciate your help in making this project better. We will look into it, and get back to you soon. Need help or want to discuss this issue? Join our Discord community here to ask questions and discuss this issue live! |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
I asked to remove the external storage permission, because has a library this is integrated in a lot of apps, that want to make the permissions as minimal as possible, like mine. So it woulde be nice if we could remove this permission |
Someone raised the same concern some time back, so to tackle this and while supporting the older version, I added this to keep up with the latest guidelines. Pdf-Viewer/pdfViewer/src/main/AndroidManifest.xml Lines 4 to 5 in a2f11aa
|
Removing the external storage permission, also has the side effect of removing some functionality of the library.
|
I believe its covered based on Android versions. Pdf-Viewer/pdfViewer/src/main/java/com/rajat/pdfviewer/PdfViewerActivity.kt Lines 427 to 447 in a2f11aa
|
Is your feature request related to a problem? Please describe.
Currently when someone imports this library, it adds to the app the permissions for external storages.
It would be nice to not impose this to the apps and remove those permissions.
Describe the solution you'd like
This library should use internal storage and remove the external storage permissions.
The text was updated successfully, but these errors were encountered: