Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to pass many parameters to cryptsetup #104

Open
vaminakov opened this issue Apr 14, 2024 · 3 comments
Open

Possibility to pass many parameters to cryptsetup #104

vaminakov opened this issue Apr 14, 2024 · 3 comments

Comments

@vaminakov
Copy link

Now line 147 of hook have quotes to each parameter:
_tmp="$(printf %s "$_ykfde_passphrase" | cryptsetup luksOpen "$YKFDE_LUKS_DEV" "$YKFDE_LUKS_NAME" "$YKFDE_LUKS_OPTIONS" 2>&1)"
So it can handle only one of them. If you have rare setup which need to pass more than one parameter, you'll not able to boot.
To fix this need just remove quotes:
_tmp="$(printf %s "$_ykfde_passphrase" | cryptsetup luksOpen "$YKFDE_LUKS_DEV" "$YKFDE_LUKS_NAME" $YKFDE_LUKS_OPTIONS 2>&1)"

@Vincent43
Copy link
Collaborator

Passing unquoted variable is something we want to avoid. Were the additional parameters about detached header?

It's also possible to store LUKS options in header

@vaminakov
Copy link
Author

@Vincent43 for example, in my configuration I'm using
--header=/header-luks.img --allow-discards

@Vincent43
Copy link
Collaborator

Yeah so we had proposal for adding headers option before.

The cryptsetup config --header=/header-luks.img <device> also should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants