Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NpmInstallPlugin to fix unintuitive-ness with compilation after installing a module #3

Open
agilgur5 opened this issue Aug 12, 2018 · 0 comments

Comments

@agilgur5
Copy link
Owner

agilgur5 commented Aug 12, 2018

The basic problem is explained well in CRA: facebook/create-react-app#186 . Unintuitive but does work eventually (I don't think I even knew it would work on the second save though, pretty sure I just thought it didn't work period :o).

facebook/create-react-app#212 (comment) and the sentiment of this issue in general is similar to some of my own reservations -- I'd much rather npm install the package myself and the auto install is different from the usual process of development without running a watcher or this plugin.
In this case, I think using react-dev-utils's WatchMissingNodeModulesPlugin might make more sense to include. That might be the only thing I would use from that package though (so installing the whole thing is a bit wasteful, but ¯\_(ツ)_/¯ )

Another important note about the NpmInstallPlugin is that it currently doesn't work with Webpack 4 and has a number of outstanding issues: webpack-contrib/install-webpack-plugin#123 . https://www.npmjs.com/package/webpack-plugin-install-deps is a fork from the PR that supports Webpack 4 fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant