forked from silviopaganini/physijs-browserify
-
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(fix): resolve incorrect browserify noParse config
- upon further testing, ammo was still being parsed by browserify until now - had to time both webpack and browserify in order to tell it wasn't being parsed, as they don't error if the module isn't found - but they both compile significantly faster when it's not, so that's how I could tell I did it correctly (probably could've used verbose mode as well) - webpack was not parsing it, but had to double check - browserify apparently only uses absolute paths, so require.resolve is the primary way of using noParse (would be great if this were better documented...) - while this is not strictly necessary for webpack, and it was working prior to this, changed the webpack config to use require.resolve as well for consistency
- Loading branch information
Showing
9 changed files
with
7 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
var THREE = require('three'); | ||
var PhysijsWorker = require('worker-loader!./physijs_worker.js'); | ||
var PhysijsWorker = require('worker-loader!./physijs/physijs_worker.js'); | ||
|
||
// inject Three.js and Physijs's Worker | ||
var Physijs = require('./physi.js')(THREE, PhysijsWorker); | ||
var Physijs = require('./physijs/physi.js')(THREE, PhysijsWorker); | ||
|
||
module.exports = Physijs; |