-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browserify test to work without errors in Node v10 #14
Comments
Ok I tried a whole ton of stuff to get all tests working and just ran into so so many issues 😢 😢 😞 In In With I did get the browserify test to run and succeed when I ran it in Idk why browserify has so many issues and even errors out in a browser. The long running time and gc errors make me think it may be related to the infinite loop/cycle issue found in #6 and that there's something very weird with |
Ok, once I added Given this fact, it's likely that the gc errors with
Anyway got it to work with decent speed, so now just to reorganize stuff and see about adding coverage reporting |
So in #13 I tried to upgrade CI to Node v10 Active LTS (v8 is EOL in January, lots of new features and performance in v10,
npm ci
, etc, etc) and that apparently caused the browserify test to start failing. I noticed this locally too, but didn't at all realize it was related to me updating my local Node version 😕Per the Travis build, the error I'm getting is:
This is coming directly from the
webworkify
code and is seems like it's becausejsdom
has not implementedURL.createObjectURL
, so it would make this acantfix
.I have no clue why it works on Node v8 and fails on Node v10 though, that doesn't really make sense to me as that doesn't change the
jsdom
version and it's not implemented in anyjsdom
version. I'm guessing it might be silently failing and this might be why the browserify tests have the coverage issues found in #6, but idk.Based on all the bugs encountered with workers /
jsdom
, I think it would make sense for this library to move to using something likecypress
or a headless browser so that all the necessary features are implemented, and hopefully then the tests will pass without errors and code coverage will actually give some results.The text was updated successfully, but these errors were encountered: