-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webpack test to work without bugs #7
Comments
Ok, pretty quick work so I just decided to do it anyway. The test passes, but I do get a
It would seem that Webpack is a bit slower than browserify also (probably bc 0CJS mode does more transforms) and had to set it to development mode to get it to be reasonable (bc wrapping ammo as always takes a toll on build times). Browserify doesn't do any transforms, minification, etc by default so dev mode should match up. |
Well, I found the Based on webpack/webpack#1747, the configuration should override the inline loader, but for some reason both end up running for me with the inlined loader being the one that's used... I definitely don't want to force users to inline their Worker by adding the config option to the inline require, but not really sure how to override it properly 😕 |
Might be related to webpack-contrib/worker-loader#194 -- Since the test passes (the Worker probably just won't work under |
Looking at the source code for |
Now that we've got a test harness and runner in #5 , should be trivial to add a webpack test that would be virtually identical to the browserify side stuff.
The text was updated successfully, but these errors were encountered: