Feat: support build metadata #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add `allow_local_segment` option test: validate `allow_local_segment` option refactor: change `allow_local_segment` to `allow_build_segment` refactor: change `allow_build_segment` to `allow_build_metadata` refactor: drop `allow_build_metadata` option
agoose77
force-pushed
the
feat-support-local
branch
from
47982f4 to
cc53c30
Compare
|
@ofek could you verify this PR fixes the mkdocs issue, please? :) |
|
|
|
That looks like success to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP #440 specifies local version identifiers. There is a similar feature in NPM called the build metadata. This PR adds support for these versions, with some caveats:
Originally this PR included an option to disable support for build metadata, but it is actually not needed, as build metadata does not break round-tripping.