Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty version string in server image #392

Open
jarkenau opened this issue Jul 11, 2024 · 0 comments
Open

Empty version string in server image #392

jarkenau opened this issue Jul 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jarkenau
Copy link
Member

Starting the server image with docker compose produces the following output:

...
seerep_server           | [2024-07-11 13:40:00.861233]<info>: SEEREP version: N/A
...

This happens because only the source files are copied in the Dockerfile, and no Git information is included:

COPY certs src/certs/
COPY seerep_com src/seerep_com/
COPY seerep_hdf5 src/seerep_hdf5/
COPY seerep_msgs src/seerep_msgs/
COPY seerep_ros src/seerep_ros/
COPY seerep_srv src/seerep_srv/
COPY examples src/examples/
COPY docker/server/start_server.sh src/start_server.sh

For tagged images, e.g (ghcr.io/agri-gaia/seerep_server:0.2.5), we should include the tag and for latest image, we could simply use latest. However, I’m not sure about the approach for implementing this.

@jarkenau jarkenau added the bug Something isn't working label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant