Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bad optional access in fb->core conversion #333

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix bad optional access in fb->core conversion #333

merged 1 commit into from
Aug 10, 2023

Conversation

Mark-Niemeyer
Copy link
Member

No description provided.

@Mark-Niemeyer Mark-Niemeyer requested a review from jarkenau August 7, 2023 13:55
@Mark-Niemeyer Mark-Niemeyer mentioned this pull request Aug 7, 2023
Closed
@Mark-Niemeyer Mark-Niemeyer added the bug Something isn't working label Aug 7, 2023
@jarkenau jarkenau force-pushed the fix/fbPolygonOptionalAccess branch from 9c3e064 to 6b984df Compare August 8, 2023 13:18
@jarkenau
Copy link
Member

jarkenau commented Aug 8, 2023

As a side note, we also have to fix other scripts that use queries, e.g.
https://github.com/agri-gaia/seerep/blob/2029d46946fdafba063cb5fccfb4e6402f8db058/examples/python/gRPC/pointcloud/gRPC_fb_queryPointCloud.py#L68-L71
https://github.com/agri-gaia/seerep/blob/2029d46946fdafba063cb5fccfb4e6402f8db058/examples/python/gRPC/images/gRPC_fb_queryImageAndVisualize.py#L74-L76

But that's for another PR.

@Mark-Niemeyer Mark-Niemeyer force-pushed the fix/fbPolygonOptionalAccess branch from 6b984df to 7cda737 Compare August 10, 2023 08:43
@Mark-Niemeyer Mark-Niemeyer merged commit 021b88b into main Aug 10, 2023
@Mark-Niemeyer Mark-Niemeyer deleted the fix/fbPolygonOptionalAccess branch August 10, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarkenau jarkenau jarkenau approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mark-Niemeyer @jarkenau