Add check for the correct layout of camera intrinsics matrices. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Niemeyer
requested changes
Jan 2, 2024
mmeijerdfki
requested review from
Mark-Niemeyer
and removed request for
Mark-Niemeyer
mmeijerdfki
force-pushed
the
fix/camintrins-matrix-layout
branch
from
c4cddb6 to
7cfb436
Compare
jarkenau
reviewed
Jan 24, 2024
jarkenau
approved these changes
Jan 24, 2024
Mark-Niemeyer
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #342. This also corrects a typo in Frustum.
Edit:
Empty values are now allowed, except for the intrinsics matrix.