Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove version pinning of apt packages in docker base image #403

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jarkenau
Copy link
Member

@jarkenau jarkenau commented Aug 6, 2024

Older versions of packages are not retained in the apt repository, leading to build failures when new packages become available. Very inconvenient that this is the default recommendation of the linter :/

@jarkenau jarkenau added docker Docker related fix labels Aug 6, 2024
@jarkenau jarkenau self-assigned this Aug 6, 2024
Copy link
Member

@Mark-Niemeyer Mark-Niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more apt install later in the Dockerfile

Older versions of packages are not retained in the apt repository,
leading to build failures when new packages become available.
See upstream issue in hadolint: hadolint/hadolint#884
@jarkenau
Copy link
Member Author

jarkenau commented Aug 6, 2024

There are some more apt install later in the Dockerfile

Oops ... Now everything should be included.

@Mark-Niemeyer Mark-Niemeyer merged commit f3f1788 into main Aug 6, 2024
8 checks passed
@Mark-Niemeyer Mark-Niemeyer deleted the fix-hadolint branch August 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants