hotkeys do not work with dvorak

[skucherenko]

Looking at the demo page, pressing Option + B (the counter should be bumped) -- nothing happens. Pressing Option + X (it'd correspond to Option + B if I'd use QWERTY and not Dvorak) -- everything works.

Expected: it says Option + B, I press Option + B, it just works
Real: Press Option + B, nothing happens. Frustrating 🤷‍♂️

[ai]

What event.key and event.code do you have on B/X presses?

What OS do you use and how did you enable Dvorak there?

[skucherenko]

Just 'B':

{
"key": "x",
"keyCode": 88,
"which": 88,
"code": "KeyB",
"location": 0,
"altKey": false,
"ctrlKey": false,
"metaKey": false,
"shiftKey": false,
"repeat": false
}

Option+B:

{
"key": "≈",
"keyCode": 88,
"which": 88,
"code": "KeyB",
"location": 0,
"altKey": true,
"ctrlKey": false,
"metaKey": false,
"shiftKey": false,
"repeat": false
}

macOS Sonoma 14.2.1

Dvorak is set up in a standard macOS way.

Karabiner-Elements is installed but it has only simple remappings for external keyboards, nothing that should affect this one.

[ai]

Can you try to remove this like and check again?

Just 'B':

Is it Dvorak’s B?

[skucherenko]

Can you try to remove this like and check again?

Just 'B':

Is it Dvorak’s B?

Sorry, here it goes:

Dvorak B, QWERTY N:

{
"key": "b",
"keyCode": 66,
"which": 66,
"code": "KeyN",
"location": 0,
"altKey": false,
"ctrlKey": false,
"metaKey": false,
"shiftKey": false,
"repeat": false
}

Dvorak X, QWERTY B
{
"key": "x",
"keyCode": 88,
"which": 88,
"code": "KeyB",
"location": 0,
"altKey": false,
"ctrlKey": false,
"metaKey": false,
"shiftKey": false,
"repeat": false
}

Works for the second one, I expect it to work on the first one.

[skucherenko]

Can you try to remove this like and check again?

not sure I understood correctly. Removed NON_ENGLISH_LAYOUT.test(event.key) && check, started locally (pnpm i && pnpm start) -- no luck

[ai]

Dvorak B, "key": "b",

Seems like it is not a problem with Dvorak.

Does those h hotkeys in demo works in Dvorak (when you press Dvorak’s h)?

[skucherenko]

Dvorak B, "key": "b",

Seems like it is not a problem with Dvorak.

Does those h hotkeys in demo works in Dvorak (when you press Dvorak’s h)?

Consecutively pressing 'h' in Dvorak and switching tabs with mouse. Looks like expected behavior:

[ai]

Hm. Seems like the problem is with Option+B.

1. Can you show Dvorak’s Option+B event object?
2. Can you debug those lines to find out why event.code was not used? https://github.com/ai/keyux/blob/main/hotkey.js#L37-L45