Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Esc hides focus instead of returns it back #32

Open
uzurpastor opened this issue Aug 2, 2024 · 2 comments
Open

Demo: Esc hides focus instead of returns it back #32

uzurpastor opened this issue Aug 2, 2024 · 2 comments

Comments

@uzurpastor
Copy link

OS: Fedora 40
Browser: Firefox 128.0, Chromium 126.0

It seems to me that incorrect behaviour is taking place here. When the Esc key is pressed, the focus does not return to the body of the first element.

But I'm sure this may depend on the specific use case, so I have an idea to provide both behaviours via some "configuration" variables, if the current lib implementation makes it easy to implement this.

ER:

  • return focus to the top

AR:

  • hide focus

Screencast:

Screencast.from.2024-08-02.11-46-11.mp4
@ai
Copy link
Owner

ai commented Aug 3, 2024

Yes, we can improve behavior here. But PR is needed. I do not need this behavior for myself but will accept changes from somebody else.

@uzurpastor
Copy link
Author

Great! I take a look on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants