fix: added missing packages to tsup configs' externals #488
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
preparing the project with
sh scripts/start.shRisks
LOW
I don't foresee any risks
Background
When I run
sh scripts/start.sh, I get errors about some packages not being able to be resolved, this seems to be the solution.What does this PR do?
Adds the missing packages to tsup confgs' externals so that they can be resolved.
What kind of change is this?
Bug fix
Why are we doing this? Any context or related work?
Issue with starting to work with the codebase
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
I ran
sh scripts/start.shuntil it didn't produce errors in the building stage.Where should a reviewer start?
This is pretty small and manageable.
Detailed testing steps
None, automtated tests are fine.
Discord username
massivefermion