Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict names in schema to lower_snake_case (breaking change) #140

Closed
domire8 opened this issue Mar 22, 2024 · 0 comments
Closed

Restrict names in schema to lower_snake_case (breaking change) #140

domire8 opened this issue Mar 22, 2024 · 0 comments
Assignees

Comments

@domire8
Copy link
Member

domire8 commented Mar 22, 2024

As a small note, our application schema restricts most namespaces to the regexp (^[a-zA-Z][a-zA-Z0-9_]*[a-zA-Z0-9]$)|(^[a-zA-Z]$), so it does not actually enforce lower case for things like named service calls in the YAML. Changing it to (^[a-z][a-z0-9_]*[a-z0-9]$)|(^[a-z]$) would be nice but would be a breaking change to the schema unfortunately (potentially invalidates previously valid schemas).

Still, we should suggest lower_snake_case in the docs and automatically sanitize to lower case in the implementation, and update the schema when the next breaking change happens.

Originally posted by @eeberhard in aica-technology/modulo#66 (comment)

@domire8 domire8 self-assigned this Mar 22, 2024
@eeberhard eeberhard changed the title Change schema along with future breaking changes Restrict names in schema to lower_snake_case (breaking change) Apr 17, 2024
@domire8 domire8 closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant