Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate images into one base image #98

Closed
domire8 opened this issue Apr 23, 2024 · 1 comment · Fixed by #104
Closed

Consolidate images into one base image #98

domire8 opened this issue Apr 23, 2024 · 1 comment · Fixed by #104
Assignees

Comments

@domire8
Copy link
Member

domire8 commented Apr 23, 2024

As discussed as part of a different initiative (public base class for modulo controllers), it was agreed that there should only be one ROS2 base image that contains all the sources for ROS2 and ROS2 Control. This has several advantages, mainly that we don't need to keep track of an additional intermediate image and that then all our repositories using ROS can use a tagged version of that one single image (see also #82).

I don't think this needs to be an epic, but the steps would be:

  1. Tag the current state of the repo as v1.0.0 (done)
  2. Remove Dockerfiles of deprecated images (not the images on GHCR itself!)
  3. Merge Dockerfiles of ros2-ws and ros2-control
  4. Update README
  5. Release the new base image with the current tags of ros2-control as v1.0.0+iron

@eeberhard @bpapaspyros @LouisBrunner

@LouisBrunner
Copy link
Contributor

Just a reminder: as discussed in #82 we should have multiple tags for each release for maximum discoverability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants