Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / restructure #5

Open
sgoodm opened this issue Aug 2, 2021 · 2 comments
Open

Refactor / restructure #5

sgoodm opened this issue Aug 2, 2021 · 2 comments
Labels
code related to code for processing data

Comments

@sgoodm
Copy link
Member

sgoodm commented Aug 2, 2021

Entire codebase is currently in a single Python file that is essentially just a final proof-of-concept / prototype. We would likely benefit (even if only in terms of readability) by breaking some of the functions out into a class in a separate file.

This would be a good opportunity to make sure code is well organized and documented with comments/docstrings.

@sgoodm sgoodm added the code related to code for processing data label Aug 2, 2021
@sgoodm
Copy link
Member Author

sgoodm commented Aug 2, 2021

Eventually we may want to create a dedicated package for extracting spatial features from OSM links so that this can be applied to other projects and used by other folks.

@sgoodm
Copy link
Member Author

sgoodm commented Aug 30, 2021

I've done a fair amount of cleaning up, documenting code, etc. but may still want to explore viability of classes and refactoring some components (and creating a dedicated package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code related to code for processing data
Projects
None yet
Development

No branches or pull requests

1 participant