Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ancestor_of and descendant_of QueryBuilder join specifications #2209

Closed
ConradJohnston opened this issue Nov 16, 2018 · 1 comment
Closed

Replace ancestor_of and descendant_of QueryBuilder join specifications #2209

ConradJohnston opened this issue Nov 16, 2018 · 1 comment
Assignees
@ConradJohnston
Labels
topic/naming-issues topic/query-builder
Milestone
v1.0.0b1

Comments

@ConradJohnston
Copy link
Contributor

In accordance with #2183, the QueryBuilder relationship indicators "ancestor_of" and "descendant_of" need to be updated to "with_descendant" and "with_ancestor", respectively.
@giovannipizzi giovannipizzi self-assigned this Nov 22, 2018
@giovannipizzi giovannipizzi added this to the v1.0.0 milestone Nov 22, 2018
@ConradJohnston ConradJohnston mentioned this issue Dec 3, 2018
Merged
@sphuber sphuber modified the milestones: v1.0.0, v1.0.0b1 Dec 4, 2018
@sphuber sphuber changed the title Replace "anscestor_of" and "descendant_of" QueryBuilder join specifications Replace ancestor_of and descendant_of QueryBuilder join specifications Dec 4, 2018
@sphuber
Copy link
Contributor

sphuber commented Dec 4, 2018

Fixed in PR #2278

@sphuber sphuber closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ConradJohnston ConradJohnston

Labels
topic/naming-issues topic/query-builder
Projects
None yet
Milestone
v1.0.0b1
Development

No branches or pull requests
3 participants
@sphuber @giovannipizzi @ConradJohnston