Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verdi export not storing full provenance #2586

Closed
ltalirz opened this issue Mar 8, 2019 · 9 comments
Closed

verdi export not storing full provenance #2586

ltalirz opened this issue Mar 8, 2019 · 9 comments
Assignees
Labels
priority/critical-blocking must be resolved before next release type/bug

Comments

@ltalirz
Copy link
Member

ltalirz commented Mar 8, 2019

We have an example of a workflow (see verdi graph ) where we would like to export the full provenance.

Starting from the final CifData (PK 132944), we created an AiiDA export file (with all options enabled to get as much of the provenance as possible: verdi export create -I -R -X -C).

We then imported the export file in a different profile and generated the graph:

  • the provenance is broken at the inline calculation (PK 131351)
  • not a single Work-type node was exported

The export file was prepared on aiida-core 0.12.2 & imported on aiida-core 0.12.3.

@ltalirz ltalirz added type/bug priority/critical-blocking must be resolved before next release labels Mar 8, 2019
@ltalirz
Copy link
Member Author

ltalirz commented Mar 8, 2019

I find this curious in a number of ways

  1. this should have been fixed in PR Support current link types/link rules (support for workchains and workflows) at the import/export #1764 , which was merged into release_v0.12.2.
  2. How is this not caught by the tests?
  3. how can verdi graph generate work but verdi export not? Is the logic (incorrectly) duplicated?

mentioning also @giovannipizzi for comment

@giovannipizzi
Copy link
Member

First question: are the Work nodes in the export file or not? (I.e. is the problem in exporting or in importing?)

@ltalirz
Copy link
Member Author

ltalirz commented Mar 8, 2019

Sorry, export file is attached above now.
No Work nodes are in the export file as far as I can tell.

@szoupanos
Copy link
Contributor

This should have been solved at the issue #1758 and PR #1764. I will look what goes wrong. Thanks Leo

@szoupanos
Copy link
Contributor

szoupanos commented Mar 25, 2019

Fixed by PR #2632 for .12

@szoupanos
Copy link
Contributor

There will be a new PR for this for 1.0 since the same problem should exist there too

@ltalirz
Copy link
Member Author

ltalirz commented Apr 10, 2020

To do: check whether this indeed still exists in develop (I would hope not?).
If not, close this issue.

@sphuber
Copy link
Contributor

sphuber commented Jun 8, 2020

Have you had the chance to look at this @ltalirz ? Since this should be fixed in 0.12.* and anyway we are no longer supporting it, I removed the label

@sphuber
Copy link
Contributor

sphuber commented Oct 4, 2020

If there really is still a problem with the provenance being broken in v1.* when exporting/importing we should find a MWE and open a new issue. Closing this as the problem was identified in 0.* and fixed there.

@sphuber sphuber closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/critical-blocking must be resolved before next release type/bug
Projects
None yet
Development

No branches or pull requests

4 participants